Fix module resolver infinite loop for Windows #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop `while dir not in invalidDirs and dir not in modulePaths` could become an infinite loop on Windows because "C:\\" is not in the list of invalid directories. Could also do this another way, but this fix should handle 99.9% of the cases (there could also be a network share like "\\share\some\path" but most developers don't use that directly).
|
Hey there, thanks for the pull request. I should have some time later in the week to pull it in and try it out. Most of the work with hem that I do is on the mac/linux world so definitely appreciate any help on the PC side of the world. thanks! |
|
@zcoffin86 since you have been helping out with hem path stuff on Windows, have any thoughts on this? |
|
Outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop
while dir not in invalidDirs and dir not in modulePathscould become an infinite loop on Windows because "C:" is not in the list of invalid directories.Could also do this another way, but this fix should handle 99.9% of the cases (there could also be a network share like "\share\some\path" but most developers don't use that directly).