Skip to content

Commit

Permalink
fix(kubernetes): add cleaned up artifact manifests to output (#3711)
Browse files Browse the repository at this point in the history
  • Loading branch information
maggieneterval committed Jun 3, 2019
1 parent 500e56a commit 15bd7fa
Showing 1 changed file with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifest;
import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifestAnnotater;
import com.netflix.spinnaker.clouddriver.kubernetes.v2.description.manifest.KubernetesManifestStrategy;
import com.netflix.spinnaker.clouddriver.kubernetes.v2.op.OperationResult;
import com.netflix.spinnaker.clouddriver.kubernetes.v2.op.handler.KubernetesHandler;
import com.netflix.spinnaker.clouddriver.kubernetes.v2.security.KubernetesV2Credentials;
import com.netflix.spinnaker.clouddriver.model.ArtifactProvider;
Expand All @@ -41,7 +42,7 @@
import org.apache.commons.lang.StringUtils;

@Slf4j
public class KubernetesCleanupArtifactsOperation implements AtomicOperation<Void> {
public class KubernetesCleanupArtifactsOperation implements AtomicOperation<OperationResult> {
private final KubernetesCleanupArtifactsDescription description;
private final KubernetesV2Credentials credentials;
private final String accountName;
Expand All @@ -65,7 +66,9 @@ private static Task getTask() {
}

@Override
public Void operate(List priorOutputs) {
public OperationResult operate(List priorOutputs) {
OperationResult result = new OperationResult();

List<Artifact> artifacts =
description.getManifests().stream()
.map(this::artifactsToDelete)
Expand Down Expand Up @@ -93,11 +96,12 @@ public Void operate(List priorOutputs) {
if (StringUtils.isNotEmpty(a.getVersion())) {
name = String.join("-", name, a.getVersion());
}
// todo add to outputs
handler.delete(credentials, a.getLocation(), name, null, new V1DeleteOptions());
result.merge(
handler.delete(credentials, a.getLocation(), name, null, new V1DeleteOptions()));
});

return null;
result.setManifests(null);
return result;
}

private List<Artifact> artifactsToDelete(KubernetesManifest manifest) {
Expand Down

0 comments on commit 15bd7fa

Please sign in to comment.