fix(appengine): check for null versions in servergroup caching agent (#…

…3875) (#3877)
spinnaker · Jul 12, 2019 · 3ca22dc · 3ca22dc
1 parent 146cd59
commit 3ca22dc
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...ix/spinnaker/clouddriver/appengine/provider/agent/AppengineServerGroupCachingAgent.groovy b/...ix/spinnaker/clouddriver/appengine/provider/agent/AppengineServerGroupCachingAgent.groovy
@@ -318,9 +318,11 @@ class AppengineServerGroupCachingAgent extends AbstractAppengineCachingAgent imp
       def callback = new AppengineCallback<ListVersionsResponse>()
         .success { ListVersionsResponse versionsResponse, HttpHeaders responseHeaders ->
           def versions = versionsResponse.getVersions()
-          versions.removeIf { shouldIgnoreServerGroup(it.getId()) }
           if (versions) {
-            serverGroupsByLoadBalancer[loadBalancer].addAll(versions)
+            versions.removeIf { shouldIgnoreServerGroup(it.getId()) }
+            if(versions) {
+              serverGroupsByLoadBalancer[loadBalancer].addAll(versions)
+            }
           }
         }