fix(provider/kubernetes): v2 Fix validation to not require namespace (#…

…2422) Access to resources that do not belong to any namespace should be permitted, since there is no namespace to use for restricting access.
spinnaker · Mar 13, 2018 · 79c3e7d · 79c3e7d
1 parent 7168d23
commit 79c3e7d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...y/com/netflix/spinnaker/clouddriver/kubernetes/v2/validator/KubernetesValidationUtil.java b/...y/com/netflix/spinnaker/clouddriver/kubernetes/v2/validator/KubernetesValidationUtil.java
@@ -85,8 +85,8 @@ public boolean validateV2Credentials(AccountCredentialsProvider provider, String
       return false;
     }
 
-    if (!validateNotEmpty("namespace", namespace)) {
-      return false;
+    if (StringUtils.isEmpty(namespace)) {
+      return true;
     }
 
     AccountCredentials credentials = provider.getCredentials(accountName);

diff --git a/...netflix/spinnaker/clouddriver/kubernetes/v2/validator/KubernetesValidationUtilSpec.groovy b/...netflix/spinnaker/clouddriver/kubernetes/v2/validator/KubernetesValidationUtilSpec.groovy
@@ -49,6 +49,8 @@ class KubernetesValidationUtilSpec extends Specification {
 
     where:
     testNamespace       || expectedResult
+    null                || true
+    ""                  || true
     "test-namespace"    || true
     "omit-namespace"    || false
     "unknown-namespace" || false