fix(provider/kubernetes): v2 Allow ":" in keys (#2420)

Colons are allowed in Kubernetes resource names, and used by default
for several RBAC roles like "system:masters".

Replace ";" with ";" when storing the key, and do the opposite when
retrieving the key.

clouddriver-kubernetes/src/main/groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/caching/Keys.java

@@ -88,6 +88,7 @@ public static LogicalKind fromString(String name) {
   private static String createKey(Object... elems) {
     List<String> components = Arrays.stream(elems)
         .map(s -> s == null ? "" : s.toString())
+        .map(s -> s.replaceAll(":", ";"))
         .collect(Collectors.toList());
     components.add(0, provider);
     return String.join(":", components);
@@ -120,6 +121,10 @@ public static Optional<CacheKey> parseKey(String key) {
       return Optional.empty();
     }
 
+    for (String part : parts) {
+      part.replaceAll(";", ":");
+    }
+
     try {
       Kind kind = Kind.fromString(parts[1]);
       switch (kind) {