fix(misc): Update error message with region and account details (#3761)

* fix(misc): Update error message with region and account details * Add region and account to metrics tag
spinnaker · Jun 6, 2019 · a812268 · a812268
1 parent aebb1b0
commit a812268
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/...com/netflix/spinnaker/clouddriver/aws/deploy/ops/DeleteAmazonSnapshotAtomicOperation.java b/...com/netflix/spinnaker/clouddriver/aws/deploy/ops/DeleteAmazonSnapshotAtomicOperation.java
@@ -63,11 +63,27 @@ public Void operate(List priorOutputs) {
           .getAmazonEC2(description.getCredentials(), description.getRegion())
           .deleteSnapshot(new DeleteSnapshotRequest().withSnapshotId(description.getSnapshotId()));
     } catch (Exception e) {
-      registry.counter(deleteSnapshotTaskId.withTag("success", false)).increment();
-      log.error(String.format("Failed to delete snapshotId %s", description.getSnapshotId()), e);
+      registry
+          .counter(
+              deleteSnapshotTaskId
+                  .withTag("success", false)
+                  .withTag("region", description.getRegion())
+                  .withTag("account", description.getAccount()))
+          .increment();
+      log.error(
+          String.format(
+              "Failed to delete snapshotId: %s , region: %s , account: %s",
+              description.getSnapshotId(), description.getRegion(), description.getAccount()),
+          e);
       throw e;
     }
-    registry.counter(deleteSnapshotTaskId.withTag("success", true)).increment();
+    registry
+        .counter(
+            deleteSnapshotTaskId
+                .withTag("success", true)
+                .withTag("region", description.getRegion())
+                .withTag("account", description.getAccount()))
+        .increment();
 
     getTask()
         .updateStatus(