fix(cf): allow environmentVars values to be deserializable to objects (…

…#3804)
spinnaker · Jun 21, 2019 · abc102e · abc102e
1 parent c778d18
commit abc102e
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 12 deletions.
diff --git a/...dry/src/main/java/com/netflix/spinnaker/clouddriver/cloudfoundry/client/Applications.java b/...dry/src/main/java/com/netflix/spinnaker/clouddriver/cloudfoundry/client/Applications.java
@@ -313,14 +313,17 @@ private CloudFoundryServerGroup map(Application application) {
                                         .build()))
                 .collect(toList());
 
-    Map<String, String> environmentVars =
+    Map<String, Object> environmentVars =
         applicationEnv == null || applicationEnv.getEnvironmentJson() == null
             ? emptyMap()
             : applicationEnv.getEnvironmentJson();
 
     final CloudFoundryBuildInfo buildInfo = getBuildInfoFromEnvVars(environmentVars);
     final ArtifactInfo artifactInfo = getArtifactInfoFromEnvVars(environmentVars);
-    final String pipelineId = environmentVars.get(ServerGroupMetaDataEnvVar.PipelineId.envVarName);
+    final String pipelineId =
+        Optional.ofNullable(environmentVars.get(ServerGroupMetaDataEnvVar.PipelineId.envVarName))
+            .map(Object::toString)
+            .orElse(null);
     Arrays.asList(ServerGroupMetaDataEnvVar.values())
         .forEach(envVar -> environmentVars.remove(envVar.envVarName));
 
@@ -375,19 +378,40 @@ private CloudFoundryServerGroup map(Application application) {
         .build();
   }
 
-  private CloudFoundryBuildInfo getBuildInfoFromEnvVars(Map<String, String> environmentVars) {
+  private CloudFoundryBuildInfo getBuildInfoFromEnvVars(Map<String, Object> environmentVars) {
     return CloudFoundryBuildInfo.builder()
-        .jobName(environmentVars.get(ServerGroupMetaDataEnvVar.JobName.envVarName))
-        .jobNumber(environmentVars.get(ServerGroupMetaDataEnvVar.JobNumber.envVarName))
-        .jobUrl(environmentVars.get(ServerGroupMetaDataEnvVar.JobUrl.envVarName))
+        .jobName(
+            Optional.ofNullable(environmentVars.get(ServerGroupMetaDataEnvVar.JobName.envVarName))
+                .map(Object::toString)
+                .orElse(null))
+        .jobNumber(
+            Optional.ofNullable(environmentVars.get(ServerGroupMetaDataEnvVar.JobNumber.envVarName))
+                .map(Object::toString)
+                .orElse(null))
+        .jobUrl(
+            Optional.ofNullable(environmentVars.get(ServerGroupMetaDataEnvVar.JobUrl.envVarName))
+                .map(Object::toString)
+                .orElse(null))
         .build();
   }
 
-  private ArtifactInfo getArtifactInfoFromEnvVars(Map<String, String> environmentVars) {
+  private ArtifactInfo getArtifactInfoFromEnvVars(Map<String, Object> environmentVars) {
     return ArtifactInfo.builder()
-        .name(environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactName.envVarName))
-        .version(environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactVersion.envVarName))
-        .url(environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactUrl.envVarName))
+        .name(
+            Optional.ofNullable(
+                    environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactName.envVarName))
+                .map(Object::toString)
+                .orElse(null))
+        .version(
+            Optional.ofNullable(
+                    environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactVersion.envVarName))
+                .map(Object::toString)
+                .orElse(null))
+        .url(
+            Optional.ofNullable(
+                    environmentVars.get(ServerGroupMetaDataEnvVar.ArtifactUrl.envVarName))
+                .map(Object::toString)
+                .orElse(null))
         .build();
   }
 

diff --git a/...n/java/com/netflix/spinnaker/clouddriver/cloudfoundry/client/model/v2/ApplicationEnv.java b/...n/java/com/netflix/spinnaker/clouddriver/cloudfoundry/client/model/v2/ApplicationEnv.java
@@ -24,7 +24,7 @@
 @Data
 public class ApplicationEnv {
   private SystemEnv systemEnvJson;
-  private Map<String, String> environmentJson;
+  private Map<String, Object> environmentJson;
 
   @Data
   public static class SystemEnv {

diff --git a/...in/java/com/netflix/spinnaker/clouddriver/cloudfoundry/model/CloudFoundryServerGroup.java b/...in/java/com/netflix/spinnaker/clouddriver/cloudfoundry/model/CloudFoundryServerGroup.java
@@ -93,7 +93,7 @@ public class CloudFoundryServerGroup extends CloudFoundryModel implements Server
   Long createdTime;
 
   @JsonView(Views.Cache.class)
-  Map<String, String> env;
+  Map<String, Object> env;
 
   @Wither
   @JsonView(Views.Cache.class)