Skip to content

Commit

Permalink
feat(aws): Track the instanceIds being disabled (#2383)
Browse files Browse the repository at this point in the history
This allows `orca` to make a more informed decision when verifying that
a specific percentage of a server group has been disabled.
  • Loading branch information
ajordens committed Feb 21, 2018
1 parent d7b270f commit c1477b1
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ abstract class AbstractEnableDisableAtomicOperation implements AtomicOperation<V
if (instanceIds && credentials.discoveryEnabled && description.desiredPercentage && disable) {
instanceIds = discoverySupport.getInstanceToModify(credentials.name, region, serverGroupName, instanceIds, description.desiredPercentage)
task.updateStatus phaseName, "Only disabling instances $instanceIds on ASG $serverGroupName with percentage ${description.desiredPercentage}"

task.addResultObjects([
["instanceIdsToDisable": instanceIds]
])
}

// ELB/ALB registration
Expand Down

0 comments on commit c1477b1

Please sign in to comment.