fix(kotlin): spring config classes shouldn't use constructors (#4054)

spinnaker · Sep 26, 2019 · dc39fb9 · dc39fb9
1 parent 21cc20a
commit dc39fb9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/cats/cats-sql/src/main/kotlin/com/netflix/spinnaker/config/SqlAgentProperties.kt b/cats/cats-sql/src/main/kotlin/com/netflix/spinnaker/config/SqlAgentProperties.kt
@@ -18,15 +18,15 @@ package com.netflix.spinnaker.config
 import org.springframework.boot.context.properties.ConfigurationProperties
 
 @ConfigurationProperties("sql.agent")
-data class SqlAgentProperties(
-  var enabledPattern: String = ".*",
-  var maxConcurrentAgents: Int = 100,
-  var agentLockAcquisitionIntervalSeconds: Long = 1,
+class SqlAgentProperties {
+  var enabledPattern: String = ".*"
+  var maxConcurrentAgents: Int = 100
+  var agentLockAcquisitionIntervalSeconds: Long = 1
   var poll: SqlPollProperties = SqlPollProperties()
-)
+}
 
-data class SqlPollProperties(
-  var intervalSeconds: Long = 30,
-  var errorIntervalSeconds: Long = 30,
+class SqlPollProperties {
+  var intervalSeconds: Long = 30
+  var errorIntervalSeconds: Long = 30
   var timeoutSeconds: Long = 300
-)
+}
diff --git a/...ddriver-sql/src/main/kotlin/com/netflix/spinnaker/config/SqlTaskCleanupAgentProperties.kt b/...ddriver-sql/src/main/kotlin/com/netflix/spinnaker/config/SqlTaskCleanupAgentProperties.kt
@@ -19,7 +19,7 @@ import org.springframework.boot.context.properties.ConfigurationProperties
 import java.util.concurrent.TimeUnit
 
 @ConfigurationProperties("sql.agent.task-cleanup")
-class SqlTaskCleanupAgentProperties(
-  var completedTtlMs: Long = TimeUnit.MINUTES.toMillis(60),
+class SqlTaskCleanupAgentProperties {
+  var completedTtlMs: Long = TimeUnit.MINUTES.toMillis(60)
   var batchSize: Int = 100
-)
+}