feat(aws): Flag to allow launching private thirdparty AMIs #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
force-pushed
the
allow-thirdpartyprivate
branch
from
d6331ce
to
04e796e
Compare
|
LGTM |
cfieber
approved these changes
Apr 26, 2017
| @@ -150,6 +149,7 @@ public void setDefaultResult(String defaultResult) { | |||
| private String assumeRole; | |||
| private String sessionName; | |||
| private List<LifecycleHook> lifecycleHooks; | |||
| private Boolean allowLaunchDescription; | |||
There was a problem hiding this comment.
You need to name this the same as the attribute on NetflixAmazonCredentials (it gets ObjectMapper.convertValue'd over there)
| @@ -49,6 +49,7 @@ | |||
| private final List<AWSRegion> regions; | |||
| private final List<String> defaultSecurityGroups; | |||
| private final List<LifecycleHook> lifecycleHooks; | |||
| private final Boolean allowPrivateThirdPartyImages; | |||
There was a problem hiding this comment.
can you make this little b boolean and assign a default value in the constructor? If we want to use this in non-groovy code it would be nice to not have to null check it
robzienert
force-pushed
the
allow-thirdpartyprivate
branch
from
04e796e
to
d8b242f
Compare
robzienert
force-pushed
the
allow-thirdpartyprivate
branch
from
d8b242f
to
8992a21
Compare
lwander
pushed a commit
to lwander/clouddriver
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some teams need the ability to launch private third-party AMIs. We don't want this capability allowed across the board, so I've added a flag that allows us to enable this on a per-account basis, which fits in well with the model that security has setup.
@spinnaker/netflix-reviewers PTAL