fix(provider/kubernetes): reduce crd lookups when none exist #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the call fails, the memoizer can't record the success time, voiding the use of an expiring memoizer. When a lot of deployments happen at once, we check all our caching agent's kinds very frequently generating a lot of calls to the "crd" kind, which are now all memoized.
dibyom
approved these changes
Aug 17, 2018
lwander
added a commit
to lwander/clouddriver
that referenced
this pull request
Aug 17, 2018
…er#2886) If the call fails, the memoizer can't record the success time, voiding the use of an expiring memoizer. When a lot of deployments happen at once, we check all our caching agent's kinds very frequently generating a lot of calls to the "crd" kind, which are now all memoized.
lwander
added a commit
that referenced
this pull request
Aug 24, 2018
…2887) If the call fails, the memoizer can't record the success time, voiding the use of an expiring memoizer. When a lot of deployments happen at once, we check all our caching agent's kinds very frequently generating a lot of calls to the "crd" kind, which are now all memoized.
mtweten
pushed a commit
to cerner/clouddriver
that referenced
this pull request
Aug 29, 2018
…er#2886) If the call fails, the memoizer can't record the success time, voiding the use of an expiring memoizer. When a lot of deployments happen at once, we check all our caching agent's kinds very frequently generating a lot of calls to the "crd" kind, which are now all memoized.
clanesf
pushed a commit
to clanesf/clouddriver
that referenced
this pull request
Dec 8, 2018
…er#2886) If the call fails, the memoizer can't record the success time, voiding the use of an expiring memoizer. When a lot of deployments happen at once, we check all our caching agent's kinds very frequently generating a lot of calls to the "crd" kind, which are now all memoized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the call fails, the memoizer can't record the success time, voiding
the use of an expiring memoizer. When a lot of deployments happen at
once, we check all our caching agent's kinds very frequently generating
a lot of calls to the "crd" kind, which are now all memoized.