feat(ecs): Copy scaling policies from source server group #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareliguori
force-pushed
the
ecs-copy-scaling-policies
branch
from
ff87dfc
to
9313864
Compare
Also: * update the dimensions with the latest ECS cluster and service name when copying scaling alarms and target tracking policies * Remove the option to configure ECS scaling alarms in the 'autoscalingPolicies' parameter, which never worked anyway * If enabled, use source server group for capacity settings (min, max, desired count) feat(ecs): Enable using previous server group's capacity
clareliguori
force-pushed
the
ecs-copy-scaling-policies
branch
from
9313864
to
f29af38
Compare
robzienert
approved these changes
Jan 15, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy scaling policies from source server group
Also:
Fixes spinnaker/spinnaker#3733, spinnaker/spinnaker#3779, and spinnaker/spinnaker#3184.
Target tracking policies will still be affected by spinnaker/spinnaker#3507