fix(ecs): allow sub-org ecr repos #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
KyleJamesWalker
changed the title
KyleJamesWalker
force-pushed
the
patch-1
branch
2 times, most recently
from
ac55ed9
to
08535fc
Compare
KyleJamesWalker
changed the title
KyleJamesWalker
changed the title
clareliguori
reviewed
May 7, 2019
...-ecs/src/main/java/com/netflix/spinnaker/clouddriver/ecs/provider/view/EcrImageProvider.java
Outdated
Show resolved
Hide resolved
KyleJamesWalker
force-pushed
the
patch-1
branch
2 times, most recently
from
37f5fe0
to
4a01282
Compare
clareliguori
approved these changes
May 8, 2019
|
@spinnaker/reviewers |
The current regex match does not match names like `111111111111.dkr.ecr.us-east-1.amazonaws.com/sub-org/my-app-image:v0.0.0`
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex match does not catch names like the following:
111111111111.dkr.ecr.us-east-1.amazonaws.com/sub-org/my-app-image:v0.0.0