fix(kubernetes): Fail validation if account has no namespaces #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before deploying a manifest, we check whether the namespace is one that the account is configured for. We do this by checking namespaces and omitNamespaces, but this fails in the case where an account is mis-configured and doesn't have any namespaces. Instead, just use getDeclaredNamespaces which returns a fully resolved list of namespaces the account knows about (whether because of config or dynamically discovered).
This was referenced Jun 5, 2019
maggieneterval
pushed a commit
that referenced
this pull request
Jun 5, 2019
In 1.14, we tried to improve the failure mode for users with misconfigured accounts by using the actual live list of namespaces while validating accounts. This fails when users are creating a namespace and deploying something to the namespace as part of the same operation; in that case the live list does not know about the namespace (but will by the time the deployment completes). This reverts #3639 (and adds a comment and test to make sure this subtle bug is not re-introduced).
spinnakerbot
pushed a commit
that referenced
this pull request
Jun 5, 2019
In 1.14, we tried to improve the failure mode for users with misconfigured accounts by using the actual live list of namespaces while validating accounts. This fails when users are creating a namespace and deploying something to the namespace as part of the same operation; in that case the live list does not know about the namespace (but will by the time the deployment completes). This reverts #3639 (and adds a comment and test to make sure this subtle bug is not re-introduced).
maggieneterval
pushed a commit
that referenced
this pull request
Jun 5, 2019
…) (#3750) In 1.14, we tried to improve the failure mode for users with misconfigured accounts by using the actual live list of namespaces while validating accounts. This fails when users are creating a namespace and deploying something to the namespace as part of the same operation; in that case the live list does not know about the namespace (but will by the time the deployment completes). This reverts #3639 (and adds a comment and test to make sure this subtle bug is not re-introduced).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before deploying a manifest, we check whether the namespace is one that the account is configured for. We do this by checking namespaces and omitNamespaces, but this fails in the case where an account is mis-configured and doesn't have any namespaces.
Instead, just use getDeclaredNamespaces which returns a fully resolved list of namespaces the account knows about (whether because of config or dynamically discovered).
Fixes spinnaker/spinnaker#4319