Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): Remove ProviderSynchronizerTypeWrapper and usage #3682

Merged
merged 4 commits into from
May 23, 2019

Conversation

scottfrederick
Copy link
Contributor

Following aaf1572, remove the ProviderSynchronizerTypeWrapper class and usage of it from all providers. This class was used to facilitate refreshing configuration via the /config-refresh controller, which was removed as part of the integration of Spring Cloud Config refresh and config server.

Also remove SCOPE_PROTOTYPE from @ConfigurationProperties beans, as these beans will get refreshed by Spring Cloud Config refresh when they are in the RefreshScope context.

@jkschneider jkschneider requested a review from cfieber May 17, 2019 00:50
@jkschneider
Copy link
Member

@cfieber I think this gets us closer to being able to just use singletons and get rid of this prototype scoped weird anti-cyclic dependency thing.

@scottfrederick
Copy link
Contributor Author

After these change, I only see one remaining use of SCOPE_PROTOTYPE in RetrofitConfig. I suspect that one can be deleted too, but I don't understand that config well enough to know for sure.

@scottfrederick
Copy link
Contributor Author

@ezimanyi @cfieber Any feedback on this mass deletion of code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants