Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): If in "host" network mode, host and container port should b… #3776

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

justinrlee
Copy link
Contributor

…e the same

When creating a task definition with the host network mode and specifying a containerPort, the containerPort should be used for both the host and container port.

Can be cherry-picked into 1.14.

Copy link
Member

@kevinawoo kevinawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@justinrlee
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.14

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit dd1a21d) with exit code 128:

fatal: bad object dd1a21df257408feca8800be0f79e1651fb37404

@ezimanyi ezimanyi merged commit ebbe104 into spinnaker:master Jun 14, 2019
@ezimanyi
Copy link
Contributor

@spinnakerbot cherry-pick 1.14

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #3791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants