feat(kubernetes,google): Support retrieving config files from config server. #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimanyi
reviewed
Jun 24, 2019
clouddriver-core/src/main/groovy/com/netflix/spinnaker/clouddriver/data/ConfigFileService.java
Outdated
Show resolved
Hide resolved
...river-core/src/test/groovy/com/netflix/spinnaker/clouddriver/data/ConfigFileServiceTest.java
Outdated
Show resolved
Hide resolved
clouddriver-web/src/test/groovy/com/netflix/spinnaker/clouddriver/MainSpec.java
Outdated
Show resolved
Hide resolved
...groovy/com/netflix/spinnaker/clouddriver/kubernetes/v2/security/KubernetesV2Credentials.java
Outdated
Show resolved
Hide resolved
ezimanyi
reviewed
Jun 25, 2019
...r-core/src/main/groovy/com/netflix/spinnaker/clouddriver/cache/CloudConfigRefreshConfig.java
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading files from an external Spring Cloud Config Server backend (e.g. a git repository) for the purposes of keeping account secrets out of Spinnaker configuration files. See the design document for more information: https://docs.google.com/document/d/1Y7SIgobc8_CCFmFZLRUGl-76sfHWlprFYGy992S5U4A/edit#heading=h.sai17pl3aws8.
The following fields have external configuration enabled with these changes:
kubernetesaccount fieldkubeconfiggoogleaccount fieldsjson-pathanduser-data-fileIf these fields have a value that starts with
configserver:then the value following the prefix will be loaded as a resource from a Config Server. Without the prefix the value will be used as an absolute path to a file on the filesystem as before.The
googleaccount fields are read from the Config Server backend into memory on the clouddriver pod, and are never written to the filesystem. Thekuberneteskubeconfigmust be read from Config Server and stored as a temp file on the pod filesystem because the Fabric8 API used by the v1 provider and thekubectlcommands used by the v2 provider both require a local file. This is an incremental improvement over storing kubernetes context info as a persistent file on the pod filesystem, as the temp file is more obfuscated and ephemeral, but we should investigate a way to remove this need for a temp file.