-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws): cli version upgrade to support eks subcommands #3848
Conversation
aws eks ...
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
@spinnaker-release please review as this is a hard bug for EKS deployments. |
Bump & more context. AWS updated their CLI in May 2019 to do the authentication without requiring external tools such as heptio https://aws.amazon.com/about-aws/whats-new/2019/05/amazon-eks-simplifies-kubernetes-cluster-authentication/ Please do upgrade the awscli to latest, or the version in this PR (which I have tested). |
cc @xavileon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, but don't have approve permissions (nor specific knowledge on this part of the codebase). Maybe @robzienert or @ezimanyi can point us to the some one with the knowledge?
I've used halyard to install spinnaker 1.14.8 onto it's own kubernetes (eks) cluster as per documentation.
I also have an EKS target to which I want to deploy, but spinnaker currently errors during a deploy manifest step:
`
s3 | configure
deploy | configservice
opsworks-cm | history
help
Invalid choice: 'eks', maybe you meant:
es error: unable to recognize "STDIN": Get https://07FB762B0FC0E678218E6AFF82087860.yl4.eu-west-1.eks.amazonaws.com/api?timeout=32s: getting credentials: exec: exit status 2
`
This is due to the
awscli
command inside the clouddriver container being too old, and the expected aws subcommand eks is missing.Fix is to upgrade to aws 1.16.x
See error:
`
s3 | configure
deploy | configservice
opsworks-cm | history
help
Invalid choice: 'eks', maybe you meant:
es error: unable to recognize "STDIN": Get https://07FB762B0FC0E678218E6AFF82087860.yl4.eu-west-1.eks.amazonaws.com/api?timeout=32s: getting credentials: exec: exit status 2
`
This change bumps the hardcoded version to 1.16.145