Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): cli version upgrade to support eks subcommands #3848

Merged
merged 5 commits into from
Jul 8, 2019
Merged

fix(aws): cli version upgrade to support eks subcommands #3848

merged 5 commits into from
Jul 8, 2019

Conversation

pieterza
Copy link
Contributor

@pieterza pieterza commented Jul 4, 2019

I've used halyard to install spinnaker 1.14.8 onto it's own kubernetes (eks) cluster as per documentation.

I also have an EKS target to which I want to deploy, but spinnaker currently errors during a deploy manifest step:

`
s3 | configure
deploy | configservice
opsworks-cm | history
help

Invalid choice: 'eks', maybe you meant:

es error: unable to recognize "STDIN": Get https://07FB762B0FC0E678218E6AFF82087860.yl4.eu-west-1.eks.amazonaws.com/api?timeout=32s: getting credentials: exec: exit status 2
`

This is due to the awscli command inside the clouddriver container being too old, and the expected aws subcommand eks is missing.

Fix is to upgrade to aws 1.16.x

See error:

`
s3 | configure
deploy | configservice
opsworks-cm | history
help

Invalid choice: 'eks', maybe you meant:

es error: unable to recognize "STDIN": Get https://07FB762B0FC0E678218E6AFF82087860.yl4.eu-west-1.eks.amazonaws.com/api?timeout=32s: getting credentials: exec: exit status 2
`

This change bumps the hardcoded version to 1.16.145

@pieterza pieterza changed the title Support aws eks ... fix support EKS target by upgrading aws cli Jul 4, 2019
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@pieterza pieterza changed the title fix support EKS target by upgrading aws cli fix(aws): cli version upgrade to support eks subcommands Jul 4, 2019
@pieterza
Copy link
Contributor Author

pieterza commented Jul 4, 2019

@spinnaker-release please review as this is a hard bug for EKS deployments.

@pieterza
Copy link
Contributor Author

pieterza commented Jul 8, 2019

Bump & more context.

AWS updated their CLI in May 2019 to do the authentication without requiring external tools such as heptio https://aws.amazon.com/about-aws/whats-new/2019/05/amazon-eks-simplifies-kubernetes-cluster-authentication/
As such the awscli subcommand of eks needs to be present to use these new kubeconfig files.

Please do upgrade the awscli to latest, or the version in this PR (which I have tested).

@pieterza
Copy link
Contributor Author

pieterza commented Jul 8, 2019

cc @xavileon

Copy link
Contributor

@xavileon xavileon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but don't have approve permissions (nor specific knowledge on this part of the codebase). Maybe @robzienert or @ezimanyi can point us to the some one with the knowledge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants