fix(kubernetes): fix property parser exception #3885
Conversation
when the property parser exountered a malformed it would throw an out of bounds exception and fail. we should just skip properties with empty values. Fixes spinnaker/spinnaker#4629
ethanfrogers
force-pushed
the
property-parser-fix
branch
from
7b03976
to
8711075
Compare
|
cc @milesmatthias - is this the behavior you would expect for malformed properties? I can see either skipping it or defaulting it to an empty string as valid behaviors. |
|
Yea, I would expect it to be skipped as well. Thanks for the quick fix @ethanfrogers! 👏 |
|
1 follow up here... either way you handle this scenario, there's a potential for extra work to be created. For example, I'm using the return value here as an override in a bake stage, and an empty string in a bake override is a valid value, so manifests are created. For me, my bake step is generating job manifests, so the command being run in the job needs to exit cleanly in the use case of |
|
@spinnakerbot cherry-pick 1.15 |
when the property parser exountered a malformed it would throw an out of bounds exception and fail. we should just skip properties with empty values. Fixes spinnaker/spinnaker#4629
|
Cherry pick successful: #3894 |
when the property parser exountered a malformed it would throw an out of bounds exception and fail. we should just skip properties with empty values. Fixes spinnaker/spinnaker#4629
when the property parser exountered a malformed it would throw an out of
bounds exception and fail. we should just skip properties with empty
values.