feat(build): Ubuntu image variant support #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 20, 2019 09:36
* New tagging format: `version-variant`, example: `1.2.3-alpine` * For backward compatibility with the buildtool system and older versions of Halyard, the alpine image variant keeps the original 'naked' version tag i.e. `1.2.3` in addition to the one with the new format. * The BOM format doesn't change, it's up to Halyard to append the right `-variant` for a tag to fetch the right image on the registry. * The Dockerfiles are meant to be used directly for ad-hoc image creation by an end-user and by the existing build system through `cloudbuild.yml`.
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
pdelagrave
changed the title
ezimanyi
approved these changes
Aug 20, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slimandubuntuare now supported and expected by the buildtool system.cloudbuild.yamlgeneric.cloudbuild.yamlis now generic for every services, removed it from the services repos and made it a single file in buildtool.Dockerfile.compileis required as the first stage to compile/build an artifact copied in the final images during the 2nd stage.docker build -t compile -f Dockerfile.compile . && docker build -f Dockerfile.[slim|ubuntu] .