fix(aws): Alter AllowLaunchDescription to not overload account #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajordens
approved these changes
Sep 11, 2019
cfieber
approved these changes
Sep 11, 2019
| public Map process(Map description) { | ||
| // Backwards-compatibility from when AllowLaunch used to overload "account" from the abstract | ||
| // AWS description. | ||
| description.put("targetAccount", description.get("account")); |
There was a problem hiding this comment.
I'd propose for this to do a putIfAbsent("targetAccount") instead otherwise callers will have to continue to supply account once they have been updated
robzienert
force-pushed
the
fix-allow-launch
branch
from
1abafbf
to
251e764
Compare
robzienert
force-pushed
the
fix-allow-launch
branch
from
251e764
to
2b58385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We asked, "What could possibly go wrong?" with #4017. It turns out
AllowLaunchDescriptionoverloadedaccount, which broke any deploy from a newly baked image. That's what can go wrong.This PR fixes that, making the description use a new field and fix-forward whatever Orca sends us.