fix(kubernetes): Fix mis-spelled API group #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The networking.k8s.io API group is mis-spelled as network.k8s.io; fix this. This bug is preventing security groups from being cached by clouddriver. We also should accept extensions/v1beta1 as the API group, which can still be returned from clusters running Kubernetes < 1.16.
|
@spinnakerbot 🍒 ⛏️ 1.17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Oct 31, 2019
* fix(kubernetes): Fix mis-spelled API group The networking.k8s.io API group is mis-spelled as network.k8s.io; fix this. This bug is preventing security groups from being cached by clouddriver. We also should accept extensions/v1beta1 as the API group, which can still be returned from clusters running Kubernetes < 1.16. * fix(kubernetes): Fix test broken by prior commit
|
Cherry pick successful: #4136 |
ttomsu
pushed a commit
that referenced
this pull request
Oct 31, 2019
* fix(kubernetes): Fix mis-spelled API group The networking.k8s.io API group is mis-spelled as network.k8s.io; fix this. This bug is preventing security groups from being cached by clouddriver. We also should accept extensions/v1beta1 as the API group, which can still be returned from clusters running Kubernetes < 1.16. * fix(kubernetes): Fix test broken by prior commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networking.k8s.io API group is mis-spelled as network.k8s.io; fix this. This bug is preventing security groups from being cached by clouddriver.
We also should accept extensions/v1beta1 as the API group, which can still be returned from clusters running Kubernetes < 1.16.