fix(kubernetes): Core caching agent is authoritative for artifacts #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no caching agent that is authoritative for kubernetes artifacts; this is causing them to fail to be cached by the SQL provider (which strictly enforces that only caching agents can only write types for which they are authoritative). The KubernetesCoreCachingAgent should be authoritative for artifacts, just as it is for other logical kinds (clusters and applications).
|
Hrmm, can this be cherry picked to 1.17? |
|
@spinnakerbot cherry-pick 1.17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jan 10, 2020
…4247) There is currently no caching agent that is authoritative for kubernetes artifacts; this is causing them to fail to be cached by the SQL provider (which strictly enforces that only caching agents can only write types for which they are authoritative). The KubernetesCoreCachingAgent should be authoritative for artifacts, just as it is for other logical kinds (clusters and applications).
|
Cherry pick successful: #4248 |
duftler
pushed a commit
that referenced
this pull request
Jan 13, 2020
…4247) (#4248) There is currently no caching agent that is authoritative for kubernetes artifacts; this is causing them to fail to be cached by the SQL provider (which strictly enforces that only caching agents can only write types for which they are authoritative). The KubernetesCoreCachingAgent should be authoritative for artifacts, just as it is for other logical kinds (clusters and applications). Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#5274.
There is currently no caching agent that is authoritative for kubernetes artifacts; this is causing them to fail to be cached by the SQL provider (which strictly enforces that only caching agents can only write types for which they are authoritative).
The KubernetesCoreCachingAgent should be authoritative for artifacts, just as it is for other logical kinds (clusters and applications).