feat(retrofit): Replace RetrofitError catch blocks and add spinnakerE… #6015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielaS12
requested review from
jeyrschabu,
ajordens,
cfieber,
zachsmith1,
plumpy and
skandragon
as code owners
|
@DanielaS12 Looks like some tests are failing. |
|
This would be easier to follow as separate commits -- one per retrofit interface. |
dbyron-sf
reviewed
Sep 7, 2023
...java/com/netflix/spinnaker/clouddriver/aws/lifecycle/InstanceTerminationLifecycleWorker.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...java/com/netflix/spinnaker/clouddriver/aws/lifecycle/InstanceTerminationLifecycleWorker.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...er-consul/src/main/groovy/com/netflix/spinnaker/clouddriver/consul/api/v1/ConsulAgent.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...r-consul/src/main/groovy/com/netflix/spinnaker/clouddriver/consul/config/ConsulConfig.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...src/main/groovy/com/netflix/spinnaker/clouddriver/consul/provider/ConsulProviderUtils.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
.../com/netflix/spinnaker/clouddriver/docker/registry/api/v2/client/DockerRegistryClient.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
.../spinnaker/clouddriver/docker/registry/provider/agent/DockerRegistryImageCachingAgent.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
.../spinnaker/clouddriver/docker/registry/provider/agent/DockerRegistryImageCachingAgent.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
.../spinnaker/clouddriver/docker/registry/security/DockerRegistryNamedAccountCredentials.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
.../spinnaker/clouddriver/docker/registry/security/DockerRegistryNamedAccountCredentials.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...main/groovy/com/netflix/spinnaker/clouddriver/eureka/deploy/ops/AbstractEurekaSupport.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 7, 2023
...main/groovy/com/netflix/spinnaker/clouddriver/eureka/deploy/ops/AbstractEurekaSupport.groovy
Outdated
Show resolved
Hide resolved
…driver/eureka/deploy/ops/AbstractEurekaSupport.groovy Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
dbyron-sf
reviewed
Sep 8, 2023
dbyron-sf
reviewed
Sep 8, 2023
...java/com/netflix/spinnaker/clouddriver/aws/lifecycle/InstanceTerminationLifecycleWorker.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 11, 2023
...java/com/netflix/spinnaker/clouddriver/aws/lifecycle/InstanceTerminationLifecycleWorker.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 11, 2023
...java/com/netflix/spinnaker/clouddriver/aws/lifecycle/InstanceTerminationLifecycleWorker.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 11, 2023
...main/groovy/com/netflix/spinnaker/clouddriver/eureka/deploy/ops/AbstractEurekaSupport.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 19, 2023
dbyron-sf
reviewed
Sep 19, 2023
...main/groovy/com/netflix/spinnaker/clouddriver/eureka/deploy/ops/AbstractEurekaSupport.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 19, 2023
...main/groovy/com/netflix/spinnaker/clouddriver/eureka/deploy/ops/AbstractEurekaSupport.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
approved these changes
Sep 21, 2023
|
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request registers SpinnakerRetrofitErrorHandler with each Retrofit.RestAdapter and replaces each RetrofitError catch block with a catch-block using SpinnakerServerException or the appropriate subclass. This is part of an effort to consume SpinnakerRetrofitErrorHandler in each Spinnaker microservice, as detailed in spinnaker/spinnaker#5473