Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oracle): introduce explicit constructor for initialization of inner class members in OracleServerGroup #6043

Merged
merged 1 commit into from Sep 15, 2023

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Sep 15, 2023

This change is to make code more readable and less dependent of groovy transformations.

@j-sandy j-sandy changed the title refactor(oracle/test): introduce explicit constructor for initialization of inner class members in OracleServerGroup refactor(oracle): introduce explicit constructor for initialization of inner class members in OracleServerGroup Sep 15, 2023
…f inner class members in OracleServerGroup.groovy

This change is to make code more readable and less dependent of groovy transformations.
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Sep 15, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 15, 2023
@mergify mergify bot merged commit 6240ce8 into spinnaker:master Sep 15, 2023
17 checks passed
@j-sandy j-sandy deleted the oracle-test-refactor branch September 19, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.33
Projects
None yet
3 participants