refactor(kubernetes/test): replace deprecated NioGroovyMethods.append() with ResourceGroovyMethods.append() during upgrade to groovy 3.x #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() with ResourceGroovyMethods.append() during upgrade to groovy 3.x While upgrading to groovy 3.0.10 and spockframework 2.0-groovy-3.0, encountered the following error due to deprecation of [NioGroovyMethods](https://javadoc.io/static/org.codehaus.groovy/groovy-all/3.0.10/org/codehaus/groovy/runtime/NioGroovyMethods.html) class: ``` No signature of method: sun.nio.fs.UnixPath.append() is applicable for argument types: (String) values: [some content] Possible solutions: append(java.io.Writer, java.lang.String), append(java.io.Writer), append(java.lang.Object), append(java.io.Reader), append(java.io.Reader, java.lang.String), append(java.lang.Object, java.lang.String) groovy.lang.MissingMethodException: No signature of method: sun.nio.fs.UnixPath.append() is applicable for argument types: (String) values: [some content] Possible solutions: append(java.io.Writer, java.lang.String), append(java.io.Writer), append(java.lang.Object), append(java.io.Reader), append(java.io.Reader, java.lang.String), append(java.lang.Object, java.lang.String) at com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesNamedAccountCredentialsSpec.should equal 2 Kubernetes accounts with same kubeconfig content(KubernetesNamedAccountCredentialsSpec.groovy:61) Suppressed: java.lang.NullPointerException at java.base/java.nio.file.Files.provider(Files.java:100) at java.base/java.nio.file.Files.delete(Files.java:1141) at java_nio_file_Files$delete.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139) at com.netflix.spinnaker.clouddriver.kubernetes.security.KubernetesNamedAccountCredentialsSpec.$spock_feature_0_0(KubernetesNamedAccountCredentialsSpec.groovy:88) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.spockframework.util.ReflectionUtil.invokeMethod(ReflectionUtil.java:198) .... 2 tests completed, 1 failed > Task :clouddriver-kubernetes:test FAILED ``` To fix this issue replaced deprecated method with ResourceGroovyMethods.append() [here](https://javadoc.io/static/org.codehaus.groovy/groovy-all/3.0.10/org/codehaus/groovy/runtime/ResourceGroovyMethods.html) Test coverage of clouddriver-kubernetes module remain same before and after refactor (Tests executed 695).
dbyron-sf
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading to groovy 3.0.10 and spockframework 2.0-groovy-3.0, encountered the following error due to deprecation of NioGroovyMethods class:
To fix this issue replaced deprecated method with ResourceGroovyMethods.append() here
Test coverage of clouddriver-kubernetes module remain same before and after refactor (Tests executed 695).