refactor(azure): fix incompatible generic type issue faced during upgrade to springboot 2.5.15 #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Nov 1, 2023
...ure/src/main/groovy/com/netflix/spinnaker/clouddriver/azure/client/AzureNetworkClient.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Nov 1, 2023
...n/groovy/com/netflix/spinnaker/clouddriver/azure/security/AzureCredentialsInitializer.groovy
Outdated
Show resolved
Hide resolved
…rade to springboot 2.5.15
While upgrading springboot 2.5.15, encounter below error in clouddriver-azure module:
```
startup failed:
/clouddriver/clouddriver-azure/src/main/groovy/com/netflix/spinnaker/clouddriver/azure/client/AzureNetworkClient.groovy: 234: [Static type checking] - Incompatible generic argument types. Cannot assign java.util.List <java.lang.Object> to: java.util.Collection <AzureAppGatewayDescription>
@ line 234, column 5.
result
^
/clouddriver/clouddriver-azure/src/main/groovy/com/netflix/spinnaker/clouddriver/azure/security/AzureCredentialsInitializer.groovy: 63: [Static type checking] - Incompatible generic argument types. Cannot assign java.util.List <java.lang.Object> to: java.util.List <AzureNamedAccountCredentials>
@ line 63, column 5.
azureAccounts
^
2 errors
> Task :clouddriver-azure:compileGroovy FAILED
```
To fix this issue use explicit typecasting of relevant variable.
dbyron-sf
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading springboot 2.5.15, encounter below error in clouddriver-azure module:
To fix this issue use explicit typecasting of relevant variable.