refactor(kubernetes): use Resilience4jHelper from kork to configure logging #6160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
approved these changes
Feb 26, 2024
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
…ogging to remove duplicate code. Log messages have changed, but only slightly. Before: Kubectl retries configured for: mock-account After: Kubectl command retries configured for: mock-account The other log messages remain the same, e.g.: Retrying Kubectl command for mock-account. Attempt spinnaker#1 failed with exception...
dbyron-sf
force-pushed
the
refactor-KubectlJobExecutor-resilience4j
branch
from
4f05c22
to
0fde129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to remove duplicate code.
Log messages have changed, but only slightly.
Before:
After:
The other log messages remain the same, e.g.: