Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builds): Fixes JVM memory for builds to be set and lowers compilation #6161

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(builds): Fixes JVM memory for builds to be set and lowers compilation #6161

merged 2 commits into from
Feb 27, 2024

Conversation

jasonmcintosh
Copy link
Member

No description provided.

@dbyron-sf
Copy link
Contributor

Looks good. Does it make sense to reduce Xmx and Xms in

clouddriver/.github/workflows/integration_tests.yml

Line 10 in 6d6afde

GRADLE_OPTS: -Dorg.gradle.daemon=false -Xmx16g -Xms16g -Xss8192k
too?

@jasonmcintosh
Copy link
Member Author

Gradle ops should override the local and ... may not even be necessary depending on the phase. The stack memory is ALSO really high to me...

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for a merge label Feb 27, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Feb 27, 2024
@mergify mergify bot merged commit 538a637 into spinnaker:master Feb 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu jeyrschabu is a code owner

@ajordens ajordens Awaiting requested review from ajordens ajordens is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.34
Projects
None yet
Milestone
No milestone
3 participants
@jasonmcintosh @dbyron-sf @spinnakerbot