Initial support for AWS Application Load Balancers #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During a deploy operation, both classic and application load balancers will be resolved by name and attached to the server group. During Enable/Disable operations, the server groups instances are attached/detached from both classic and application load balancers.
cfieber
changed the title
|
WCGW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is treating the ALB the same as we treat an ELB - you request it by the name of the load balancer, and your server group is attached to all the target groups for that load balancer.
LoadBalancer names are not unique across classic and application load balancers, so currently this will attach both the classic and the application load balancer that match the requested name - not really sure that is the best strategy. We could fail the deploy if this was the case, we could just use the classic LB if it matches on name (I guess more backwards compatible?)
I could also see us having to evolve the deploy description if we want to support fancier ALB use cases (only attach my server group to a specific target group, not to every target group in the ALB). I'm sure at some point that will be a request...
@spinnaker/netflix-reviewers PTAL