fix(core): Filter flashes on non-fetchOnDemand apps (#8329)

spinnaker · Jun 12, 2020 · 0634363 · 0634363
1 parent e76e565
commit 0634363
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/app/scripts/modules/core/src/cluster/allClusters.controller.js b/app/scripts/modules/core/src/cluster/allClusters.controller.js
@@ -32,7 +32,6 @@ module(CORE_CLUSTER_ALLCLUSTERS_CONTROLLER, [
   'serverGroupCommandBuilder',
   function($scope, app, $uibModal, $timeout, insightFilterStateModel, serverGroupCommandBuilder) {
     this.$onInit = () => {
-      insightFilterStateModel.filtersHidden = true; // hidden to prevent filter flashing for on-demand apps
       const groupsUpdatedSubscription = ClusterState.filterService.groupsUpdatedStream.subscribe(() =>
         clusterGroupsUpdated(),
       );
@@ -51,7 +50,7 @@ module(CORE_CLUSTER_ALLCLUSTERS_CONTROLLER, [
         .ready()
         .then(
           () => {
-            insightFilterStateModel.filtersHidden = false;
+            insightFilterStateModel.filtersHidden = Boolean(this.dataSource.fetchOnDemand);
             updateClusterGroups();
           },
           () => this.clustersLoadError(),