fix(core/pipeline): make dropdown option labels always be strings (#7322

) Also do not repeat '* required' text
spinnaker · Aug 14, 2019 · 1251159 · 1251159
1 parent 1e779ef
commit 1251159
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/app/scripts/modules/core/src/pipeline/manualExecution/Parameters.tsx b/app/scripts/modules/core/src/pipeline/manualExecution/Parameters.tsx
@@ -87,23 +87,23 @@ export class Parameters extends React.Component<IParametersProps> {
                           {...props}
                           clearable={false}
                           inputClassName={'parameter-option-select'}
-                          options={parameter.options.map(o => ({ label: o.value, value: o.value }))}
+                          options={parameter.options.map(o => ({ label: `${o.value}`, value: o.value }))}
                         />
                       )}
                       required={parameter.required}
                     />
                   </div>
                 )}
-                {hasRequiredParameters && (
-                  <div className="form-group">
-                    <div className="col-md-4 col-md-offset-4">
-                      <em>* Required</em>
-                    </div>
-                  </div>
-                )}
               </div>
             );
           })}
+        {hasRequiredParameters && (
+          <div className="form-group sp-margin-l-top">
+            <div className="col-md-4 col-md-offset-4">
+              <em>* Required</em>
+            </div>
+          </div>
+        )}
       </>
     );
   }