Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/pipeline): make dropdown option labels always be strings #7322

Conversation

christopherthielen
Copy link
Contributor

Also do not repeat '* required' text

Copy link
Contributor

@alanmquach alanmquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christopherthielen christopherthielen merged commit 1251159 into spinnaker:master Aug 14, 2019
@christopherthielen christopherthielen deleted the manual-execution-non-string-dropdown-values branch August 14, 2019 20:08
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (spinnaker#7325)
0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (spinnaker#7323)
1251159 fix(core/pipeline): make dropdown option labels always be strings (spinnaker#7322)
1e779ef perf(core): avoid nested looping in execution transformation (spinnaker#7217)
bec54df refactor(core): Reactify the pipeline trigger configuration (spinnaker#7318)
christopherthielen added a commit that referenced this pull request Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (#7325)
0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (#7323)
1251159 fix(core/pipeline): make dropdown option labels always be strings (#7322)
1e779ef perf(core): avoid nested looping in execution transformation (#7217)
bec54df refactor(core): Reactify the pipeline trigger configuration (#7318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants