Skip to content

Commit

Permalink
chore(settings): remove defaultCategory from settings.js (#7550)
Browse files Browse the repository at this point in the history
It seems this setting is no longer used by any code
  • Loading branch information
christopherthielen committed Oct 23, 2019
1 parent a71f76d commit 2d78431
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion app/scripts/modules/core/src/config/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ export interface ISpinnakerSettings {
};
checkForUpdates: boolean;
debugEnabled: boolean;
defaultCategory: string;
defaultInstancePort: number;
defaultProviders: string[];
defaultTimeZone: string; // see http://momentjs.com/timezone/docs/#/data-utilities/
Expand Down
1 change: 0 additions & 1 deletion halconfig/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ window.spinnakerSettings = {
gistId: changelogGistId,
},
checkForUpdates: false,
defaultCategory: 'serverGroup',
defaultInstancePort: 80,
defaultProviders: [
'appengine',
Expand Down
3 changes: 2 additions & 1 deletion settings.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

// Use environment variables when developing locqlly via 'yarn start', i.e.:
// API_HOST=https://gate.spinnaker.mycompany.com yarn start
var apiHost = process.env.API_HOST || 'http://localhost:8084';
var artifactsEnabled = process.env.ARTIFACTS_ENABLED === 'true';
var artifactsRewriteEnabled = process.env.ARTIFACTS_REWRITE_ENABLED === 'true';
Expand Down Expand Up @@ -50,7 +52,6 @@ window.spinnakerSettings = {
},
checkForUpdates: true,
debugEnabled: debugEnabled,
defaultCategory: 'serverGroup',
defaultInstancePort: 80,
defaultProviders: ['appengine', 'aws', 'azure', 'cloudfoundry', 'dcos', 'ecs', 'gce', 'kubernetes', 'oracle'],
defaultTimeZone: process.env.TIMEZONE || 'America/Los_Angeles', // see http://momentjs.com/timezone/docs/#/data-utilities/
Expand Down

0 comments on commit 2d78431

Please sign in to comment.