Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(settings): remove defaultCategory from settings.js #7550

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

christopherthielen
Copy link
Contributor

It seems this setting is no longer used by any code

Please review and let me know if this looks safe to remove.

It seems this setting is no longer used by any code
@christopherthielen christopherthielen requested review from erikmunson and removed request for aglover October 23, 2019 16:54
Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo corrected, but actual change is great 🙏

@@ -1,5 +1,7 @@
'use strict';

// Use environment variables when developing locqlly via 'yarn start', i.e.:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Use environment variables when developing locqlly via 'yarn start', i.e.:
// Use environment variables when developing locally via 'yarn start', i.e.:

@christopherthielen christopherthielen merged commit 2d78431 into spinnaker:master Oct 23, 2019
@christopherthielen christopherthielen deleted the config-tweak branch October 23, 2019 17:18
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
)

It seems this setting is no longer used by any code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants