Skip to content

Commit

Permalink
fix(ssl/apache2): Port conflict in ports.conf.gen (#7225) (#7233)
Browse files Browse the repository at this point in the history
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000`
Happening only when SSL was enabled.
Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden:
- https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES
- https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen

In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
  • Loading branch information
spinnakerbot authored and ezimanyi committed Jul 16, 2019
1 parent 38ca01f commit 5041dde
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions docker/ports.conf.gen
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,4 @@ Listen {%DECK_HOST%}:{%DECK_PORT%}

<IfModule ssl_module>
SSLPassPhraseDialog exec:/etc/apache2/passphrase
Listen {%DECK_PORT%}
</IfModule>

<IfModule mod_gnutls.c>
Listen {%DECK_PORT%}
</IfModule>
</IfModule>

0 comments on commit 5041dde

Please sign in to comment.