-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssl/apache2): Port conflict in ports.conf.gen #7225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000` Happening only when SSL was enabled. Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden: - https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES - https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
Jammy-Louie
approved these changes
Jul 15, 2019
@spinnakerbot cherry-pick 1.15 |
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jul 16, 2019
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000` Happening only when SSL was enabled. Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden: - https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES - https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
Cherry pick successful: #7233 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jul 16, 2019
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000` Happening only when SSL was enabled. Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden: - https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES - https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
Cherry pick successful: #7234 |
ezimanyi
pushed a commit
that referenced
this pull request
Jul 16, 2019
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000` Happening only when SSL was enabled. Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden: - https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES - https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
ezimanyi
pushed a commit
that referenced
this pull request
Jul 16, 2019
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38): `(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000` Happening only when SSL was enabled. Starting from apache2 2.4.28, having multiple `Listen` directive listening to the same socket is forbidden: - https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/CHANGES - https://httpd.apache.org/docs/2.4/mod/mpm_common.html#listen In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deck pod was failing to start after a recent apache2 version bump in the image(2.4.25 to 2.4.38):
(98)Address already in use: AH00072: make_sock: could not bind to address 0.0.0.0:9000
Happening only when SSL was enabled.
Starting from apache2 2.4.28, having multiple
Listen
directive listening to the same socket is forbidden:In this case, no need for multiple Listen directive as we always listen on one socket whether SSL is enabled or not.