fix(core/securityGroup): Clone cached data before mutating it (#8447)

Closes #8444
spinnaker · Jul 30, 2020 · 5a502e7 · 5a502e7
1 parent a731253
commit 5a502e7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/scripts/modules/core/src/securityGroup/securityGroupReader.service.ts b/app/scripts/modules/core/src/securityGroup/securityGroupReader.service.ts
@@ -17,6 +17,7 @@ import { ISecurityGroupSearchResult } from './securityGroupSearchResultType';
 import { ProviderServiceDelegate, PROVIDER_SERVICE_DELEGATE } from 'core/cloudProvider/providerService.delegate';
 import { IMoniker } from 'core/naming/IMoniker';
 import { IEntityTags } from 'core/domain/IEntityTags';
+import { cloneDeep } from 'lodash';
 
 export interface ISecurityGroupsByAccount {
   [account: string]: {
@@ -297,7 +298,7 @@ export class SecurityGroupReader {
     const cache = InfrastructureCaches.get('securityGroups');
     const cached = cache ? cache.get('allGroups') : null;
     if (cached) {
-      return this.$q.resolve(this.decompress(cached));
+      return this.$q.resolve(this.decompress(cloneDeep(cached)));
     }
     return API.one('securityGroups')
       .get()