Skip to content

Commit

Permalink
fix(core/pipeline): stop searching stage context, being greedy about …
Browse files Browse the repository at this point in the history
…parentExecutions (#7127)
  • Loading branch information
Erik Munson committed Jun 18, 2019
1 parent 8fe74bc commit 5c4facb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion app/scripts/modules/core/src/help/help.contents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const helpContents: { [key: string]: string } = {
<ul>
<li>Name</li>
<li>Trigger</li>
<li>Context - server groups, bakery results, etc.</li>
</ul>`,
'pipeline.config.triggers.respectQuietPeriod': `
<p>The quiet period is a system operator designated period of time when automated pipelines and deploys should not run.</p>`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,8 @@ export class ExecutionFilterService {
}
const searchText = [execution.name];
searchText.push(execution.id);
searchText.push(this.getValuesAsString(execution.appConfig));
searchText.push(this.getValuesAsString(execution.trigger));
execution.stages.forEach(stage =>
searchText.push(this.getValuesAsString(stage.context, ['commits', 'jarDiffs', 'kato.tasks'])),
);
searchText.push(this.getValuesAsString(execution.trigger, ['parentExecution']));

execution.searchField = searchText.join(' ').toLowerCase();
}

Expand Down

0 comments on commit 5c4facb

Please sign in to comment.