fix(core/pipeline): stop searching stage context, being greedy about parentExecutions #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
commented
Jun 18, 2019
| @@ -137,10 +137,8 @@ export class ExecutionFilterService { | |||
| const searchText = [execution.name]; | |||
| searchText.push(execution.id); | |||
| searchText.push(this.getValuesAsString(execution.appConfig)); | |||
There was a problem hiding this comment.
@anotherchrisberry do you happen to remember whether appConfig is still a valid thing to search on? If not I'll rip it out too.
There was a problem hiding this comment.
might as well remove it
anotherchrisberry
approved these changes
Jun 18, 2019
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Jun 18, 2019
939d608 fix(pipeline): fix invisible parameter when default is not in options (spinnaker#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (spinnaker#7127) 8fe74bc fix(core): do not inject default execution window values on render (spinnaker#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (spinnaker#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (spinnaker#7080) c358801 refactor(core): Reactify ExecutionWindows component (spinnaker#7113) 744123d fix(artifact): use artifact icons in server group link (spinnaker#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (spinnaker#7114) 4e2f749 refactor(core): reactify overrideFailure component (spinnaker#7107) 4f07aeb fix(core): Make template table list scrollable (spinnaker#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (spinnaker#7102)
anotherchrisberry
pushed a commit
that referenced
this pull request
Jun 18, 2019
939d608 fix(pipeline): fix invisible parameter when default is not in options (#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (#7127) 8fe74bc fix(core): do not inject default execution window values on render (#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (#7080) c358801 refactor(core): Reactify ExecutionWindows component (#7113) 744123d fix(artifact): use artifact icons in server group link (#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (#7114) 4e2f749 refactor(core): reactify overrideFailure component (#7107) 4f07aeb fix(core): Make template table list scrollable (#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (#7102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we let folks to a text search on the name, id, trigger, and stage context of an execution. Later we stopped actually loading in full stage context data for un-expanded executions to improve some performance problems, but that had the side effect of making context search pretty weird and seemingly non-deterministic from a user point of view (due to not knowing whether a value would be available or left out of search).
Two changes:
parentExecutionfields on triggers: we were trying to stringify all the fields (including nesting) on each trigger, but sometimes that includes aparentExecution. Because we didn't explicitly omit that field, we'd end up also making every single value in the entire parent execution available for searching on the child. This has lead to some totally bizarre search resultsIn a perfect world with infinite time, it'd be nice to use a backend search that could do more advanced filtering and continue to let people search in stage context, but in the near-term I'm making the case that our current user confusion is worse than not being able to search in context at all.