fix(plugins): Fix linter error and rename file

spinnaker · Dec 17, 2019 · 932a947 · 932a947
1 parent 179c5f1
commit 932a947
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/app/scripts/modules/core/src/core.module.ts b/app/scripts/modules/core/src/core.module.ts
@@ -27,7 +27,7 @@ import { RECENT_HISTORY_SERVICE } from 'core/history';
 require('root/app/fonts/spinnaker/icons.css');
 
 import './analytics/GoogleAnalyticsInitializer';
-import { pluginSupport } from './plugins/pluginSupport';
+import { sharedLibraries } from './plugins/sharedLibraries';
 import { ANALYTICS_MODULE } from './analytics/angulartics.module';
 import { APPLICATION_BOOTSTRAP_MODULE } from './bootstrap';
 import { APPLICATION_MODULE } from './application/application.module';
@@ -94,7 +94,7 @@ templates.keys().forEach(function(key) {
   templates(key);
 });
 
-pluginSupport.exposeSharedLibraries();
+sharedLibraries.exposeSharedLibraries();
 
 export const CORE_MODULE = 'spinnaker.core';
 module(CORE_MODULE, [

diff --git a/...modules/core/src/plugins/pluginSupport.ts → ...dules/core/src/plugins/sharedLibraries.ts b/...modules/core/src/plugins/pluginSupport.ts → ...dules/core/src/plugins/sharedLibraries.ts
@@ -1,9 +1,9 @@
 import * as lodash from 'lodash';
 import * as react from 'react';
-import * as react_dom from 'react-dom';
-import * as spinnaker_core from '@spinnaker/core';
+import * as reactDOM from 'react-dom';
+import * as spinnakerCore from '@spinnaker/core';
 
-export const pluginSupport = {
+export const sharedLibraries = {
   sharedLibraryNames: [
     'lodash',
     'react',
@@ -13,6 +13,7 @@ export const pluginSupport = {
     '@spinnaker/core',
   ],
 
+  // This is the global (window) variable that the shared libs will be exposed on
   globalVariablePrefix: 'spinnaker.plugins.sharedLibraries',
 
   sanitizeLibraryName(libraryName: string): string {
@@ -31,8 +32,8 @@ export const pluginSupport = {
     if (destinationObject) {
       exposeSharedLibrary('lodash', lodash);
       exposeSharedLibrary('react', react);
-      exposeSharedLibrary('react-dom', react_dom);
-      exposeSharedLibrary('@spinnaker/core', spinnaker_core);
+      exposeSharedLibrary('react-dom', reactDOM);
+      exposeSharedLibrary('@spinnaker/core', spinnakerCore);
     }
   },
 };