fix(core/pipeline): use fresh trigger + stage list for upstream flag …

…validation (#7765)
spinnaker · Jan 10, 2020 · 99c08cb · 99c08cb
1 parent 86832e6
commit 99c08cb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/scripts/modules/core/src/pipeline/config/validation/upstreamHasFlagValidator.builder.ts b/app/scripts/modules/core/src/pipeline/config/validation/upstreamHasFlagValidator.builder.ts
@@ -15,17 +15,17 @@ export interface IUpstreamFlagProvidedValidationConfig extends IValidatorConfig
 }
 
 export const buildUpstreamHasFlagValidator = (flag: keyof IStageOrTriggerTypeConfig, name: string) => {
-  const providingStages = Registry.pipeline.getStageTypes().filter(x => x[flag]);
-  const providingTriggers = Registry.pipeline.getTriggerTypes().filter(x => x[flag]);
-  const defaultProviders = providingStages.concat(providingTriggers);
-
   PipelineConfigValidator.registerValidator(name, {
     validate: (
       pipeline: IPipeline,
       stage: IStage,
       validator: IUpstreamFlagProvidedValidationConfig,
       _config: IStageOrTriggerTypeConfig,
     ) => {
+      const providingStages = Registry.pipeline.getStageTypes().filter(x => x[flag]);
+      const providingTriggers = Registry.pipeline.getTriggerTypes().filter(x => x[flag]);
+      const defaultProviders = providingStages.concat(providingTriggers);
+
       const genericUpstreamValidator = new StageOrTriggerBeforeTypeValidator();
       const repositoryProviders = validator.getProviders ? validator.getProviders() : defaultProviders;
       const stageTypes: string[] = uniq(map(repositoryProviders, 'key'));