Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): export rollout restart stage so it's actually available for use #10037

Merged
merged 2 commits into from Oct 1, 2023
Merged

fix(kubernetes): export rollout restart stage so it's actually available for use #10037

merged 2 commits into from Oct 1, 2023

Conversation

mattgogerly
Copy link
Member

Turns out if you don't export the code it doesn't run. Who knew!

@mattgogerly
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/build.yml without workflows permission

@mattgogerly mattgogerly merged commit c19f9ce into spinnaker:master Oct 1, 2023
2 checks passed
@mattgogerly mattgogerly deleted the fix/rolling-restart branch October 1, 2023 20:33
@mattgogerly
Copy link
Member Author

@Mergifyio backport release-1.32.x

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023 •
edited

backport release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 2, 2023
@mattgogerly @mergify
fix(kubernetes): export rollout restart stage so it's actually availa…
0a47770 
…ble for use (#10037)

(cherry picked from commit c19f9ce)
@mergify mergify bot mentioned this pull request Oct 2, 2023
Merged
mergify bot added a commit that referenced this pull request Oct 2, 2023
@mergify @mattgogerly
fix(kubernetes): export rollout restart stage so it's actually availa…
028ca72 
…ble for use (#10037) (#10043)

(cherry picked from commit c19f9ce)

Co-authored-by: Matt Gogerly <6519811+mattgogerly@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target-release/1.33
Projects
None yet
Milestone
No milestone
2 participants
@mattgogerly @spinnakerbot