Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lambda): available Runtimes shared between Deploy stage and Functions tab #10050

Merged
merged 2 commits into from Oct 24, 2023
Merged

fix(lambda): available Runtimes shared between Deploy stage and Functions tab #10050

merged 2 commits into from Oct 24, 2023

Conversation

christosarvanitis
Copy link
Contributor

@christosarvanitis christosarvanitis commented Oct 23, 2023 •
edited

Having the Lambda available Runtimes defined in 2 places creates a drift between what is available in the deploy stage vs what it is available for manual creation of a Lambda function through the Functions tab.

Image 2023-10-23 at 17 50 55

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 18e6f81: Fix: Exporting availableRuntimes from the Stage definition for the Functions infra tab

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@christosarvanitis christosarvanitis changed the title fix(lambda): Available Runtimes shared between Deploy stage and Functions tab fix(lambda): available Runtimes shared between Deploy stage and Functions tab Oct 23, 2023
@christosarvanitis christosarvanitis marked this pull request as ready for review October 23, 2023 14:53
@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Oct 24, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 24, 2023
@mergify mergify bot merged commit 889d769 into spinnaker:master Oct 24, 2023
4 checks passed
@christosarvanitis
Copy link
Contributor Author

@Mergifyio backport release-1.30.x release-1.31.x release-1.32.x

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023

backport release-1.30.x release-1.31.x release-1.32.x

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@ovidiupopa07
Copy link
Contributor

https://github.com/Mergifyio backport release-1.30.x release-1.31.x release-1.32.x

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023 •
edited

backport release-1.30.x release-1.31.x release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@christosarvanitis @mergify
fix(lambda): available Runtimes shared between Deploy stage and Funct…
4ed45b0 
…ions tab (#10050)

* Fix: Exporting availableRuntimes from the Stage definition for the Functions infra tab

* Fixing formatting - prettier

(cherry picked from commit 889d769)
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@christosarvanitis @mergify
fix(lambda): available Runtimes shared between Deploy stage and Funct…
c359242 
…ions tab (#10050)

* Fix: Exporting availableRuntimes from the Stage definition for the Functions infra tab

* Fixing formatting - prettier

(cherry picked from commit 889d769)
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@christosarvanitis @mergify
fix(lambda): available Runtimes shared between Deploy stage and Funct…
1462dc1 
…ions tab (#10050)

* Fix: Exporting availableRuntimes from the Stage definition for the Functions infra tab

* Fixing formatting - prettier

(cherry picked from commit 889d769)
This was referenced Oct 24, 2023
Closed
Closed
Merged
mergify bot added a commit that referenced this pull request Oct 24, 2023
@mergify @christosarvanitis
fix(lambda): available Runtimes shared between Deploy stage and Funct…
1813846 
…ions tab (#10050) (#10054)

* Fix: Exporting availableRuntimes from the Stage definition for the Functions infra tab

* Fixing formatting - prettier

(cherry picked from commit 889d769)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesisOsorio nemesisOsorio nemesisOsorio approved these changes

@ovidiupopa07 ovidiupopa07 ovidiupopa07 approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
4 participants
@christosarvanitis @spinnakerbot @ovidiupopa07 @nemesisOsorio