feat(gitlab) - Add gitlab as a gitSource and allow gitSources to be configured via settings.js #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figured via settings.js Gitlab scm support was recently added to igor, this extends that addition to deck. This also enables the gitSources to be overridden in configuration via settings.js/settings-local.js.
jeckhart
changed the title
|
LGTM |
ethanfrogers
added a commit
to ethanfrogers/deck
that referenced
this pull request
May 10, 2018
adds gitlab as a default git source. spinnaker#4657 added the ability to override this via `settings-local.js`. it seems like the default should be all available git sources with the ability to pare down as necessary
ethanfrogers
added a commit
that referenced
this pull request
May 10, 2018
adds gitlab as a default git source. #4657 added the ability to override this via `settings-local.js`. it seems like the default should be all available git sources with the ability to pare down as necessary
amanya
pushed a commit
to amanya/deck
that referenced
this pull request
Jul 25, 2018
…figured via settings.js (spinnaker#4657) Gitlab scm support was recently added to igor, this extends that addition to deck. This also enables the gitSources to be overridden in configuration via settings.js/settings-local.js.
amanya
pushed a commit
to amanya/deck
that referenced
this pull request
Jul 25, 2018
adds gitlab as a default git source. spinnaker#4657 added the ability to override this via `settings-local.js`. it seems like the default should be all available git sources with the ability to pare down as necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab scm support was added to igor in spinnaker/spinnaker#2047 .This extends that addition to deck.
This also allows the gitSources to be overridden in configuration via settings.js/settings-local.js.