Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gitlab CI as Git and CI provider in Igor #2047

Closed
mdirkse opened this issue Oct 20, 2017 · 53 comments
Closed

Support Gitlab CI as Git and CI provider in Igor #2047

mdirkse opened this issue Oct 20, 2017 · 53 comments
Labels

Comments

@mdirkse
Copy link

mdirkse commented Oct 20, 2017

At my company we use Gitlab as an SCM hosting solution and we use Gitlab CI to do our CI. We also use Spinnaker, triggering pipelines when new docker images are added to the registry, but we'd like to have the tighter integration that is available for Jenkins (and Travis) and Github (and Stash and Bitbucket).

For this to happen Igor (and various interface things in Deck) would need to be extended to support Gitlab CI.

@tomaslin
Copy link
Contributor

can you describe what you mean by tighter integration and outline what you're trying to do in each service?

@mdirkse
Copy link
Author

mdirkse commented Nov 13, 2017

There are 2 use cases I want to support:

First: the v2 Kubernetes provider will allow the direct application of manifest files via Spinnaker. These manifest files can be sourced in a couple of ways, including having Spinnaker pick them up directly from SCM. Currently the only SCM providers supported by Igor are Stash/Bitbucket and Github. I want to add Gitlab as that's what we use.

Second: Spinnaker provides integration with Jenkins and Travis that allows Spinnaker to kick off jobs in those CI engines, get triggered by jobs and generally do more than is possible with just a web hook. I'd like to implement the same kind of integration with Gitlab CI as, once again, that's what we use.

@tweakmy
Copy link

tweakmy commented Jun 14, 2018

Is this now possible kubernetes v2 provider? Is there any documentation on how this can be done?

@mdirkse
Copy link
Author

mdirkse commented Jun 15, 2018

No docs yet, and fetching stuff from gitlab is not yet supported.

@lwander
Copy link
Member

lwander commented Jun 15, 2018

Fetching from gitlab is supported as of 1.8 (the release candidate can be tried at version release-1.8.x-latest-unvalidated): https://www.spinnaker.io/reference/artifacts/types/gitlab-file/

@tweakmy
Copy link

tweakmy commented Jun 15, 2018

Does one need to deploy igor and how (through hal pod)?

@banghuaji
Copy link

banghuaji commented Jun 28, 2018

the doc also supported ,there is no gitlab

artifacts:
gcs:
enabled: false
accounts: []
github:
enabled: true
accounts:
- name: my-github-artifact-account
tokenFile: /home/spinnaker/.hal/default/staging/dependencies/528498863-github
http:
enabled: false
accounts: []
s3:
enabled: false
accounts: []

@vdoodala
Copy link

any update on triggering pipeline in spinnaker through gitlab ?

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@ilansh
Copy link

ilansh commented Sep 2, 2018

@spinnakerbot remove-label to-be-closed

@jasonmcintosh
Copy link
Member

@spinnakerbot remove-label to-be-closed

@northrup
Copy link

I take it by the endless "remove-label-to-be-closed" that there has been no progress on this and no involvement from developers. Is there any way to push this forward? I am in the same circumstances having a GitLab instance for our SCM and CI and wanting to use Spinnaker for a tighter integration between the two.

@dnsmichi
Copy link

@northrup I was planning to look into this in the coming months, and add my thoughts or code. For now, I cannot tell exactly when and how unfortunately.

@northrup
Copy link

Thanks @dnsmichi - I’ll keep my fingers crossed. Really hoping for this!

@jasonmcintosh
Copy link
Member

I will say that artifacts & triggers work pretty well today :)

@karlskewes
Copy link
Contributor

Same thoughts as Jason.
Since this issue was created we have started using webhooks with object store artifacts to achieve desired results.
Be nice to have webhook token/auth support rather than use x509 or basic auth not otherwise all good.

@spinnakerbot
Copy link

This issue is tagged as 'stale' and hasn't been updated in 45 days, so we are tagging it as 'to-be-closed'. It will be closed in 45 days unless updates are made. If you want to remove this label, comment:

@spinnakerbot remove-label to-be-closed

@metri
Copy link

metri commented Apr 9, 2020

@spinnakerbot remove-label to-be-closed

@metri
Copy link

metri commented Apr 11, 2020

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@metri
Copy link

metri commented May 27, 2020

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@NicolaiSchmid
Copy link

@spinnakerbot remove-label stale

@spinnakerbot
Copy link

This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:

@spinnakerbot remove-label stale

@metri
Copy link

metri commented Aug 27, 2020

@spinnakerbot remove-label stale

@ahmei0
Copy link

ahmei0 commented Sep 23, 2020

@jasonmcintosh please advise if this feature was ever implemented.

i.e. I need to trigger by spinnaker pipeline when a commit is made in gitlab repo - but I don't want to push webhook from gitlab to spinnaker as it needs spinnaker api to be public. So my requirement is Spinnaker does a detect/poll on gitlab commits

@cfieber cfieber added the sig/ci label Oct 9, 2020
@gal-yardeni
Copy link

Hi @ahmei0, I don't think Spinnaker is currently able to detect/poll gitlab commits without setting up a webhook. I'm going to close this issue it's pretty old and it's hard to follow. I'd recommend opening a new issue if needed, although I suspect that it's a missing functionality as of now (contributions are welcomed!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests