Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make one request per pipeline/strategy re-indexing event #6519

Merged

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Feb 8, 2019

Previously, we made one request per pipeline to be re-indexed after re-ordering or deleting a pipeline, which could flood the Tasks panel when an application contained many pipelines.

Corresponding PRs:
Gate: spinnaker/gate#723
Orca: spinnaker/orca#2663
Front50: spinnaker/front50#448

@anotherchrisberry
Copy link
Contributor

LGTM - let's hold off merging this until we get the Orca and Gate PRs merged and deployed here at Netflix. We'll try to do that Monday.

@maggieneterval
Copy link
Contributor Author

Updated per discussion to post to new /reorder endpoints rather than the potentially more dangerous /bulkUpdate endpoints.

@maggieneterval maggieneterval merged commit 6fd4bf3 into spinnaker:master Feb 14, 2019
anotherchrisberry added a commit that referenced this pull request Feb 18, 2019
* chore(core): Bump version to 0.0.332

b18a815 fix(aws): fix security group rule updates (#6564)
1b42413 fix(core): use $timeout to handle change event in accountSelectField (#6563)
8199164 fix(core/css): be explicit on which file we're importing (#6554)
c4287c6 feat(core): display unescaped JSON if pipeline parameter input was JSON (#6556)
6fd4bf3 fix(core): make one request per pipeline/strategy re-indexing event (#6519)
592073f fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
c17c742 fix(eslint): Fix eslint warnings for @typescript-eslint/no-empty
d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
9818dec fix(eslint): Fix eslint warnings for @typescript-eslint/array-type
93d83d6 fix(eslint): Fix eslint warnings for @typescript-eslint/no-namespace
e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define
aa4e8df fix(eslint): Fix eslint warnings for @typescript-eslint/ban-types
cccca97 fix(eslint): Fix eslint warnings for no-extra-boolean-cast
3b8fcd9 fix(eslint): Fix eslint warnings for no-console
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations

* chore(amazon): Bump version to 0.0.172

b18a815 fix(aws): fix security group rule updates (#6564)
7692c2e fix(eslint): Fix eslint warnings for noundef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants