fix(executions): URI Encode pipeline names #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was me |
|
Any reason not to just stick the URI encoding in ApiService and encode all the path segments there for all requests? |
|
Haha, I meant boot2? Yeah, unfortunately there is already some encoding going on in random spots so if I were to add it in ApiService, we'd end up with some double encoding which would be bad. This was more of a quick fix. We should probably do a proper sweep and push the encoding down to ApiService and remove it everywhere else. |
anotherchrisberry
added a commit
that referenced
this pull request
May 14, 2019
* chore(core): Bump version to 0.0.363 8edcc22 fix(core): show no results message on v2 search (#6982) 1bbd936 feat(core): allow dynamic resolution of docker insights URL (#6981) 84db0ef fix(cf): reorg build info details on server group detail and summary (#6983) c48a017 fix(core): Add expected artifacts to inheritable mptv2 collections (#6975) a21e95e refactor(core): Reactified parameters for triggers (#6923) e439d2c feat(gcb): allow pre-artifacts-rewrite expected artifacts to be selected in gcb stage (#6948) fc50576 fix(executions): URI Encode pipeline names (#6971) 7007830 fix(server group): show a CI build link in server group.buildinfo (#6967) a79edb0 feat(core): Enable manual execution of mptv2 pipelines (#6968) * chore(amazon): Bump version to 0.0.189 b576fed refactor(amazon): de-angularize load balancer transformer (#6984) 1fcdf7c fix(aws): add NLB info to target group help text (#6977) 52d89d6 feat(cloudformation): support cfn tags (#6928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people (I won't mention who), don't like bracket so we need to encode them or Gate will blow up.