Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is on #6973

Merged

Conversation

jkschneider
Copy link
Member

Fixes this display when the artifactsRewrite feature flag is on:

image

@maggieneterval
Copy link
Contributor

@jkschneider does the artifactsRewrite feature flag not presuppose that the artifact feature flag is on?

@jkschneider
Copy link
Member Author

@maggieneterval they are mutually exclusive.

Copy link

@Jammy-Louie Jammy-Louie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkschneider jkschneider merged commit 96ac95a into spinnaker:master May 16, 2019
@jkschneider
Copy link
Member Author

@spinnakerbot cherry-pick 1.14

@jkschneider jkschneider deleted the artifacts-pipeline-execution branch May 16, 2019 14:07
spinnakerbot pushed a commit that referenced this pull request May 16, 2019
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7014

jkschneider pushed a commit that referenced this pull request May 16, 2019
erikmunson added a commit to erikmunson/deck that referenced this pull request May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (spinnaker#7018)
53cb422 refactor(kubernetes): convert deploy manifest stage to react (spinnaker#7002)
96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (spinnaker#6973)
5b6ad2a fix(core): Hide "Run as user" when using managed service users (spinnaker#7013)
erikmunson added a commit that referenced this pull request May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (#7018)
53cb422 refactor(kubernetes): convert deploy manifest stage to react (#7002)
96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (#6973)
5b6ad2a fix(core): Hide "Run as user" when using managed service users (#7013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants