-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is on #6973
Merged
jkschneider
merged 3 commits into
spinnaker:master
from
jkschneider:artifacts-pipeline-execution
May 16, 2019
Merged
fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is on #6973
jkschneider
merged 3 commits into
spinnaker:master
from
jkschneider:artifacts-pipeline-execution
May 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctsRewrite is enabled
@jkschneider does the |
@maggieneterval they are mutually exclusive. |
Jammy-Louie
approved these changes
May 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
May 16, 2019
…ctsRewrite is enabled (#6973)
Cherry pick successful: #7014 |
erikmunson
added a commit
to erikmunson/deck
that referenced
this pull request
May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (spinnaker#7018) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (spinnaker#7002) 96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (spinnaker#6973) 5b6ad2a fix(core): Hide "Run as user" when using managed service users (spinnaker#7013)
erikmunson
added a commit
that referenced
this pull request
May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (#7018) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (#7002) 96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (#6973) 5b6ad2a fix(core): Hide "Run as user" when using managed service users (#7013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this display when the
artifactsRewrite
feature flag is on: