fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
commented
May 17, 2019
| import { Application } from '@spinnaker/core'; | ||
| import { Subject } from 'rxjs/Subject'; | ||
|
|
||
| type IPipelineTriggerConfig = Omit<IPipelineTrigger, 'parentExecution' | 'parentPipelineId' | 'user' | 'rebake'>; |
There was a problem hiding this comment.
this was a maybe-temporary way of accurately typing what's really an acceptable input to onTriggerUpdated. I'd like to investigate how feasible having config-only trigger interfaces would be so we can use those in configs rather than the interfaces for triggers that show up in executions.
erikmunson
commented
May 17, 2019
|
|
||
| export interface IPipelineTriggerConfigProps { | ||
| status: string[]; | ||
| trigger: IPipelineTrigger; | ||
| application: Application; | ||
| pipelineId: string; | ||
| triggerUpdated: (trigger: IPipelineTrigger) => void; | ||
| triggerUpdated: (trigger: IPipelineTriggerConfig) => void; |
There was a problem hiding this comment.
this is fine for now because the thing that passes in triggerUpdated is a vanilla JS file 🤷♂
alanmquach
approved these changes
May 17, 2019
erikmunson
added a commit
to erikmunson/deck
that referenced
this pull request
May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (spinnaker#7018) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (spinnaker#7002) 96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (spinnaker#6973) 5b6ad2a fix(core): Hide "Run as user" when using managed service users (spinnaker#7013)
erikmunson
added a commit
that referenced
this pull request
May 17, 2019
80af468 fix(core/pipeline): fix type mismatch in pipeline trigger, broken webhook trigger (#7018) 53cb422 refactor(kubernetes): convert deploy manifest stage to react (#7002) 96ac95a fix(artifacts): Artifacts are shown on pipeline execution when artifactsRewrite is enabled (#6973) 5b6ad2a fix(core): Hide "Run as user" when using managed service users (#7013)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few fixes for the new react-powered pipeline and webhook triggers:
Sets coming fromChecklistto arrays, which got masked by the fact that theonUpdateTriggermethod is typed withany. End result was that once a status was changed the underlying JSON was malformed and made the trigger component un-renderable on the next navigation to the same viewPipelineTriggerlike not triggering thedestroy$subject on unmount and not using the pre-existingstatuslist if one existed